Skip to content

fix: fix datahub loop result collation#978

Merged
hwixley merged 12 commits intodevfrom
bugfix/fix-datahub-loop-result-collation
Apr 20, 2026
Merged

fix: fix datahub loop result collation#978
hwixley merged 12 commits intodevfrom
bugfix/fix-datahub-loop-result-collation

Conversation

@hwixley
Copy link
Copy Markdown
Contributor

@hwixley hwixley commented Apr 15, 2026 •
edited
Loading

Context

Fix datahub loop result collation - previously multiple results were not collated properly causing tool results to be lost

What

  • Fixes datahub tool result collation
  • Adds better exception handling on wrap_async
  • Deprecates wrap_async event loop to leverage existing one in parent caller run_with_timeout

Have you written unit tests?

  • Yes
  • No (add why you have not)

Are there any specific instructions on how to test this change?

  • Yes (if so provide more detail)
  • No

Relevant links

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026

Your PR has commits that are missing the Signed-off-by trailer. This is likely due to the pre-commit hook not being configured on your local machine. The usual fix for this issue is to run pre-commit install --install-hooks --overwrite -t commit-msg -t pre-commit, however for more detailed help in setting up the pre-commit hooks, follow the instructions at https://github.com/uktrade/github-standards/blob/main/README.md#usage

@github-actions
Copy link
Copy Markdown
Contributor

github-actions Bot commented Apr 15, 2026 •
edited
Loading

Dependency Review

✅ No vulnerabilities or OpenSSF Scorecard issues found.

Scanned Files

None

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 15, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 82.40%. Comparing base (b7f1872) to head (f694c93).

Files with missing lines Patch % Lines
redbox/redbox/api/format.py 50.00% 2 Missing ⚠️
redbox/redbox/graph/nodes/processes.py 95.00% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##              dev     #978      +/-   ##
==========================================
+ Coverage   82.20%   82.40%   +0.20%     
==========================================
  Files         197      197              
  Lines        8133     8152      +19     
==========================================
+ Hits         6686     6718      +32     
+ Misses       1447     1434      -13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hwixley hwixley marked this pull request as ready for review April 15, 2026 15:47
@hwixley hwixley requested a review from a team as a code owner April 15, 2026 15:47
dougmills-DIT
dougmills-DIT reviewed Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@dougmills-DIT dougmills-DIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add unit tests to prove the bug is fixed?

lizzie-perry-dbt
lizzie-perry-dbt approved these changes Apr 17, 2026
View reviewed changes
Copy link
Copy Markdown

@lizzie-perry-dbt lizzie-perry-dbt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good :)

Comment thread redbox/redbox/graph/nodes/processes.py
Comment thread redbox/redbox/graph/nodes/processes.py Outdated
@hwixley hwixley requested a review from dougmills-DIT April 17, 2026 15:28
@hwixley hwixley merged commit fdbc4fe into dev Apr 20, 2026
17 of 18 checks passed
@hwixley hwixley deleted the bugfix/fix-datahub-loop-result-collation branch April 20, 2026 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dougmills-DIT dougmills-DIT dougmills-DIT approved these changes

@lizzie-perry-dbt lizzie-perry-dbt lizzie-perry-dbt approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@hwixley @codecov-commenter @dougmills-DIT @lizzie-perry-dbt